[libcollections] Fix unused import warnings during stage0 build #25935
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Hmm, is this the sort of thing that needs to hang around forever, or is just pending a new snapshot? |
|
@gankro I'm not sure. Sorry, I'm new to working on rust. What's the effect of taking a new snapshot? |
|
Stage0 is building the current source from a snapshot binary build of the source from a while back. This often means stage0 has to do some trippy stuff to bridge the gap between today's and yesterday's Rust. Taking a new snapshot makes the gap smaller and thus reduces the amount of conditional things the source needs to include to handle this. If this doesn't pop up in stage1 or 2 I assume that's the problem, but since 1.0 I haven't kept up on what the snapshot "process" is. |
Gankra
added
the
T-libs-api
|
Basically I like the idea of cleaning up the output, but not if it's just making more work for a temporary thing. We're doing triage tomorrow, and I'll look into what's up with this then. Thanks for the contribution, though! |
|
Sure. Thanks for the explanation! I initially only noticed the warnings On Sun, May 31, 2015, 6:53 PM Alexis Beingessner [email protected]
|
|
I think this isn't related to the stage0 build but rather unit tests (which means that these need to stick around for awhile), just to clarify! I'll add a few comments inline. |
| @@ -37,11 +37,10 @@ | |||
| #![feature(unsafe_no_drop_flag, filling_drop)] | |||
| #![feature(step_by)] | |||
| #![feature(str_char)] | |||
| #![feature(str_words)] | |||
| #![cfg_attr(not(test), feature(str_words))] | |||
There was a problem hiding this comment.
Could you move this down near the other cfg_attr features?
wesleywiser
force-pushed
the
fix_libcollection_build_warnings
branch
from
4d751b7 to
558491c
Compare
|
@alexcrichton Thanks for the feedback! I've pushed a new commit with your suggestions. |
| @@ -79,6 +79,10 @@ | |||
| #![doc(primitive = "slice")] | |||
| #![stable(feature = "rust1", since = "1.0.0")] | |||
|
|
|||
| //Many of the usings in this module are only used in the test configuration. | |||
There was a problem hiding this comment.
Conventionally we have a space after the last slash (e.g. // foo)
wesleywiser
force-pushed
the
fix_libcollection_build_warnings
branch
from
558491c to
99df383
Compare
|
@alexcrichton Fixed. Thanks! |
…r=alexcrichton Fixes a bunch of warnings that are generated during the stage0 build of libcollections.
Fixes a bunch of warnings that are generated during the stage0 build of libcollections.